-
Notifications
You must be signed in to change notification settings - Fork 22
[ISSUE #94] Proto enhancement for "RIP‐83 Lite Topic" #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianye1001
reviewed
Sep 28, 2025
qianye1001
reviewed
Sep 28, 2025
lizhimins
previously requested changes
Oct 10, 2025
apache/rocketmq/v2/service.proto
Outdated
} | ||
|
||
message NotifyUnsubscribeLiteCommand { | ||
string liteTopic = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lite_topic
apache/rocketmq/v2/service.proto
Outdated
// consumer group | ||
Resource group = 3; | ||
// lite subscription set of lite topics | ||
repeated string liteTopicSet = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use "_"
23fa55b
to
1ab81e4
Compare
Change-Id: I7d6abc466ad153d5fe3a9c0fa40d40886ba7a203
Change-Id: Ide23812ed2df0b7a7c51605b05faf0a7efd332c2
Change-Id: I4df0503e361102c87f7f70afe4e5d88741d84e39
1ab81e4
to
a1a955f
Compare
lizhimins
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageType: LITE
andClientType: LITE_PUSH_CONSUMER
;SyncLiteSubscription
forMessagingService
;SystemProperties
,AckMessageEntry
,ForwardMessageToDeadLetterQueueRequest
to support lite topic;Related Issue: #94